Refactor to use context.app API instead of global state#1
Merged
Conversation
Contributor
isamu
commented
Jan 20, 2026
isamu
commented
- Remove roles.ts and DEFAULT_ROLES (app should own roles)
- Get roles from context.app.getRoles() at execute time
- Call context.app.switchRole() instead of globalThis.switchRole
- Add createToolDefinition(roles) for dynamic enum generation
- Keep fallback TOOL_DEFINITION for backward compatibility
- Remove roles.ts and DEFAULT_ROLES (app should own roles) - Get roles from context.app.getRoles() at execute time - Call context.app.switchRole() instead of globalThis.switchRole - Add createToolDefinition(roles) for dynamic enum generation - Keep fallback TOOL_DEFINITION for backward compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.